Improve StringBuilder.ToString() exception message for inconsistent state - #132483
Merged
jeffhandley merged 1 commit intoAug 20, 2026
Merged
Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
dotnet-policy-service
Bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-runtime |
aw0lid
marked this pull request as ready for review
August 18, 2026 20:23
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
bartonjs
reviewed
Aug 18, 2026
aw0lid
force-pushed
the
fix/stringbuilder-tostring-exception-message
branch
from
August 18, 2026 23:38
78ec096 to
aad46c3
Compare
jeffhandley
approved these changes
Aug 20, 2026
Member
|
/backport to release/11.0 |
Contributor
|
Started backporting to |
Merged
4 tasks
jeffhandley
pushed a commit
that referenced
this pull request
Aug 21, 2026
… inconsistent state (#132582) ## Customer Impact - [ ] Customer reported - [x] Found internally `StringBuilder.ToString()` could report an incorrect `ArgumentOutOfRangeException` parameter name and message when internal chunk boundaries are inconsistent, typically due to concurrent modification. This fix improves the diagnostic while preserving the exception type; no behavioral change is expected for valid, non-concurrent usage. ## Regression - [ ] Yes - [x] No ## Testing Existing tests validate the exception type for this invalid internal state. No tests were added or changed by this backport; the change is limited to the exception parameter name and reuse of an existing resource string. ## Risk Low. The backport changes only the exception parameter name and selected existing resource string for an already-invalid internal state, preserving the existing exception type and normal behavior. Build Analysis and the PR CI will provide additional validation. Backport of #132483 Co-authored-by: Ahmed Waleed <ahmedwalidahmed.0@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #131674.
Summary
When internal chunk boundaries are inconsistent (typically due to concurrent modification),
StringBuilder.ToString()previously threw anArgumentOutOfRangeExceptionwithchunkLengthas the parameter name.While the exception type is kept for compatibility, the message and parameter name are corrected. This PR updates the exception to use a clear, dedicated resource string indicating internal state corruption rather than a fictitious method parameter.
Changes
StringBuilder.ToString()to throwArgumentOutOfRangeExceptionwithnullparameter name and a proper descriptive message (SR.InvalidOperation_ConcurrentOperationsNotSupported).